Added Population Component (Specific to MR) #77
Conversation
skaldarnar
added
the
Type: Improvement
src/main/java/org/terasology/metalrenegades/population/component/PopulationComponent.java
Outdated
Show resolved
Hide resolved
src/main/java/org/terasology/metalrenegades/population/component/PopulationComponent.java
Outdated
Show resolved
Hide resolved
| public class PopulationSystem extends BaseComponentSystem { | ||
|
|
||
| @In | ||
| LocalPlayer player; |
There was a problem hiding this comment.
What happens when a authority system gets the LocalPlayer injected? I've never asked myself that question, now I'm curious 🤔 anybody knows?
I'm a bit concerned this may cause trouble in multi-player.
| public void onPlayerSpawn(OnActivatedComponent event, EntityRef entity, ClientComponent component) { | ||
|
|
||
| entity.addComponent(new PopulationComponent()); | ||
| logger.error("Component PopulationComponent added to player"); |
There was a problem hiding this comment.
this is obviously not an error 😅 (I guess this just to see that it actually works).
src/main/java/org/terasology/metalrenegades/population/system/PopulationSystem.java
Outdated
Show resolved
Hide resolved
| @ReceiveEvent | ||
| public void citizenSpawned(CitizenSpawnedEvent event, EntityRef citizen) { | ||
| FactionAlignmentComponent factionAlignmentComponent = citizen.getComponent(FactionAlignmentComponent.class); | ||
| PopulationComponent populationComponent = player.getClientEntity().getComponent(PopulationComponent.class); |
There was a problem hiding this comment.
I don't know whether there is already a settlement entity in MetalRenegades, but my gut feeling says it would be nice to get the affected settlement from the CitizenSpawnedEvent. This settlement entity (or component) would then have a reference to the population:
PopulationComponent populationComponent = event.getSettlement().getPopulation();(please don't take the exact syntax for granted)
src/main/java/org/terasology/metalrenegades/population/system/PopulationSystem.java
Outdated
Show resolved
Hide resolved
…nt/PopulationComponent.java Co-authored-by: Tobias Nett <[email protected]>
…nt/PopulationComponent.java Co-authored-by: Tobias Nett <[email protected]>
…PopulationSystem.java Co-authored-by: Tobias Nett <[email protected]>
…PopulationSystem.java Co-authored-by: Tobias Nett <[email protected]>
…into topic/PopulationCounter
| * | ||
| * The population is usually tracked by the {@link PopulationSystem}. | ||
| */ | ||
| public class MetalRenegadesPopulationComponent implements Component { |
There was a problem hiding this comment.
Something like FactionDistributionComponent might be a better name for this?
|
|
||
| EntityRef homeEntity = homeComponent.building; | ||
| SettlementRefComponent settlementRefComponent = homeEntity.getComponent(SettlementRefComponent.class); | ||
| EntityRef settlementEntity = settlementRefComponent.settlement; |
There was a problem hiding this comment.
It might be cleaner to pass the settlement entity and the faction alignment through the CitizenSpawnedEvent. This event is only emitted here and all that information is available.
| import org.terasology.entitySystem.event.Event; | ||
| import org.terasology.protobuf.EntityData; |
Population Component
Note: This has not been tested (due to technical reasons). Would be great if somebody else tested it.